Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiviewer border and additional box properties #169

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Julusian
Copy link
Member

About the Contributor

This pull request is posted on behalf of Companion

Type of Contribution

This is a: Feature

Current Behavior

New Behavior

Testing Instructions

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 67.64706% with 33 lines in your changes missing coverage. Please review.

Project coverage is 83.35%. Comparing base (1b9a6eb) to head (10b8633).

Files with missing lines Patch % Lines
...tings/MultiViewerWindowOverlayPropertiesCommand.ts 60.00% 16 Missing ⚠️
...commands/Settings/MultiViewerBorderColorCommand.ts 64.00% 9 Missing ⚠️
...s/Settings/MultiViewerWindowSafeAreaTypeCommand.ts 72.41% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   83.62%   83.35%   -0.27%     
==========================================
  Files         191      194       +3     
  Lines        6057     6157     +100     
  Branches      956     1008      +52     
==========================================
+ Hits         5065     5132      +67     
- Misses        960     1025      +65     
+ Partials       32        0      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants