Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: add common Go linter, fix #21 #34

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Commits on Sep 9, 2024

  1. workflows: add common Go linter, fix #21

    This tries to unify golangci-lint settings we use across ~20 Go repositories
    and simplify maintenance. In general, we have two sources of golangci.yml
    files copied across different repositories: neofs-node and neo-go. They differ:
     * neofs-node doesn't care about tests, neo-go does
     * neofs-node has additional settings for gofmt/gomodguard/revive
     * neo-go has additional settings for issues with exclusions
     * neo-go doesn't use exhaustive
     * neofs-node doesn't use bodyclose/contextcheck/decorder/errorlint
    
    The golangci.yml added here:
     * cares about tests
     * uses additional rules from neofs-node, they're useful
     * drops exclusions made by neo-go settings, but keeps includes
     * enables all linters from both worlds
    
    Which practically means that it causes some pain below the spine for just about
    any repository. But likely those can be fixed.
    
    Signed-off-by: Roman Khimov <[email protected]>
    roman-khimov committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    730fc2d View commit details
    Browse the repository at this point in the history