Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check: set lastBlockTime in PrepareRequest handler, fix #55 #56

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roman-khimov
Copy link
Member

It's the earliest point, if a view change happens the timer is reset (because
new view comes with a new set of transactions, potentially picking up ones
received between views).

@roman-khimov
Copy link
Member Author

Four nodes, 1000 TPS:
ms_per_block_single
Same with 200ms network delay:
ms_per_block_single

@roman-khimov
Copy link
Member Author

Max performance for four nodes with 5s block time:
tps_single
ms_per_block_single

With 200ms delay:
tps_single
ms_per_block_single

I'm not entirely sure why, but does affect TPS and not in a good way (hence this is a draft).

@roman-khimov
Copy link
Member Author

Two seconds with 128K pool:
tps_single
ms_per_block_single

It's the earliest point, if a view change happens the timer is reset (because
new view comes with a new set of transactions, potentially picking up ones
received between views).

Signed-off-by: Roman Khimov <[email protected]>
@roman-khimov
Copy link
Member Author

Rebased.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.35%. Comparing base (96105d0) to head (4c7e221).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   63.31%   63.35%   +0.04%     
==========================================
  Files          27       27              
  Lines        1510     1512       +2     
==========================================
+ Hits          956      958       +2     
  Misses        489      489              
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant