Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topic/delete flashsence #472

Merged
merged 3 commits into from
Nov 14, 2024
Merged

topic/delete flashsence #472

merged 3 commits into from
Nov 14, 2024

Conversation

TsurutaYoshiki
Copy link
Collaborator

PR の目的

  • フロントエンド、バックエンドにあったflasesence関連のコードを削除しました

経緯・意図・意思決定

バックエンド

  • apiについて以下の3件を削除しました。またapi削除に伴いテストの方も削除しています。
    • @router.post("/flashsense/check") def check_fs()
    • @router.get("/flashsense/info", response_model=FsServerInfo) def get_fs_info()
    • @router.get("/fetch_fs/{topic_id}", response_model=schemas.FsTopicSummary) def fetch_data_from_flashsense( )

フロントエンド

  • Topic作成、PTeamのGenaral setting、ATeamのGenaral settingにあったflashsence関連の機能について削除しました。

mshim03
mshim03 previously approved these changes Nov 13, 2024
Copy link
Collaborator

@mshim03 mshim03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mshim03 mshim03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshim03 mshim03 merged commit 53299e7 into main Nov 14, 2024
7 checks passed
@mshim03 mshim03 deleted the topic/delete-flashsence branch November 14, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants