Remove exception monad and cats dependency #190
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovelten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft attempt at removing exception monad from state-flow and remove cats dependency, replacing it with internal version on state.clj.
As it is right now, it is a breaking change. Needs to be changed so that it doesn't break users.
Breaking changes:
Before: running a flow with exception would return a pair of Exception monad and the last state.
After: it returns a regular Throwable instance and the last state.
Before: We could use any cats.core helpers for composing flows
Now: We should use only helpers from state-flow.state namespace, or actually preferably from state-flow.api if you are not developing a helper library. cats.core helpers will no longer be compatible.
Last commit was AI assisted, I didn't check it, we need to review it more carefully later. 🙈