feat: Add Interactive mode with target selection#1437
feat: Add Interactive mode with target selection#1437Danielku15 wants to merge 5 commits intonuke-build:developfrom
Conversation
| void ReportSummary(Configure<Dictionary<string, string>> configurator = null); | ||
|
|
||
| internal IReadOnlyCollection<ExecutableTarget> ExecutableTargets { get; } | ||
| IReadOnlyCollection<ExecutableTarget> ExecutableTargets { get; } |
There was a problem hiding this comment.
From my side this change was intentional. To properly be able to override and customize OnNoTargetsSpecified() developers need access to the general list of targets which are there as option.
e.g. in some projects we'd like to only be able to have a "single target" selection as this fits the project setup better and would like to change the default "multi selection" implementation shipped in nuke.
As alternative I could pass the executableTargets a parameter to OnNoTargetsSpecified.
1131d5a to
dc902f8
Compare
|
I wouldn't go for "automatically detect local terminal and execute the interactive mode when no parameters given". I would rather add an option on |
@ITaluone I agree and there are some considerations around that in the proposal. One important detail in this implementation is: there is an additional
|
df620ac to
482f5ac
Compare
I confirm that the pull-request:
This PR contains a proposal how #1436 could be implemented. Structurally we should still discuss where what should go but it already gives a feeling on what a user gets with this change.
Current design decisions
InvokedTargetloading logic into theExecutableTargetFactoryNukeBuildto allow people overriding and customizing it.ExecutableTargetspublic so custom implementations can use it.Terminalclass.--helpAny feedback is welcome to complete this change.
Demo
rider64_xcwuHlW2Dh.mp4