Fix iOS playback error for certain Android-compressed videos #339
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rving original audio channel count
2 tasks
numandev1
approved these changes
Mar 7, 2025
|
released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an iOS playback error that occurs when playing certain videos compressed by the Android app. The AAC decoder on iOS fails with errors such as
maxSFB long exceeds maximum allowed valuedue to incorrect audio channel settings.Root Cause
The issue was caused by the
AudioSampleEntry.setup()method, which forced mono audio (1 channel) to be treated as stereo (2 channels). This resulted in incorrect audio format information that iOS couldn't decode properly.Solution
Fixed by preserving the original audio channel count during compression.
Testing
Verified that the fix resolves playback errors on iOS for affected videos.
Related Issue
Fixes #268.