Skip to content

fix/revert gha recipe changes #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 20, 2025
Merged

fix/revert gha recipe changes #1223

merged 6 commits into from
May 20, 2025

Conversation

swap357
Copy link
Contributor

@swap357 swap357 commented May 16, 2025

This PR reverts all changes that were made to recipe, buildscript for GHA workflows.

  • CONDA_BUILD_SYSROOT now moved to osx-64 workflow as env variable.
  • reverted testing steps on linux buildscript.

@swap357 swap357 changed the title fix/revert recipe changes for gha fix/revert gha recipe changes May 16, 2025
@swap357 swap357 marked this pull request as ready for review May 19, 2025 23:26
@swap357
Copy link
Contributor Author

swap357 commented May 20, 2025 •
edited
Loading

reverted these to pre-GHA state -

conda-recipes/llvmdev/conda_build_config.yaml
conda-recipes/llvmdev_for_wheel/conda_build_config.yaml
conda-recipes/llvmlite/conda_build_config.yaml

@esc esc added Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm 4 - Waiting on CI and removed 3 - Ready for Review labels May 20, 2025
@esc
Copy link
Member

esc commented May 20, 2025

This is currently being tested on the Anaconda build farm as llvmlite_363 if that passes, this PR can be marked as Ready To Merge (RTM).

@esc
Copy link
Member

esc commented May 20, 2025

This is currently being tested on the Anaconda build farm as llvmlite_363 if that passes, this PR can be marked as Ready To Merge (RTM).

Only a single windows build failed due to a temporary network issue. This PR is about fixing osx-64 builds and that has started working again, so this is RTM.

@esc esc added BuildFarm Passed For PRs that have been through the buildfarm and passed 5 - Ready to merge and removed Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm 4 - Waiting on CI labels May 20, 2025
esc
esc approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esc esc merged commit c356949 into numba:main May 20, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esc esc esc approved these changes

Assignees
No one assigned
Labels
5 - Ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swap357 @esc @kc611