👷(deployment) restrict build-and-push github actions to merge #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjeammet
force-pushed
the
mpj/restrict-docker-build-and-push-to-merging-releases
branch
2 times, most recently
from
d8b7c86
to
a35f52d
Compare
mjeammet
force-pushed
the
mpj/restrict-docker-build-and-push-to-merging-releases
branch
3 times, most recently
from
f62eb41
to
f9bcba6
Compare
|
As for sharding, this PR is stuck indefinitely by branch protection rules
Do you confirm I can safely remove protection rules on |
|
Yes I think you can remove protections rules. As I said you have to keep in mind that maybe sometimes the build will failed on main and no new docker image will be deployed. |
Morendil
approved these changes
Oct 30, 2024
CI builds and pushes back and frontend images to DockerHub every time we push to the repo. I want to relax the CI a little, restricting images builds and pushes to merges on main.
Morendil
force-pushed
the
mpj/restrict-docker-build-and-push-to-merging-releases
branch
from
f9bcba6
to
e94a947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The CI builds and pushes back-end and front-end images to DckerHub every time we push to the repo, including on branches.
I want to relax the CI a little, restricting images builds and pushes to what is necessary (merges on main only, from what I know)
Proposal
Description...
Last we spoke, Antoine sounded surprised that images would build outside of tagging but, from what I understood, staging might still need a docker images for kubernetes deployement. But build and push after merging on main might suffice.
To be discussed.