🔥(teams) remove pagination of teams listing #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morendil
force-pushed
the
sdem/remove_pagination
branch
3 times, most recently
from
938d8f6
to
7f3923a
Compare
Morendil
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Unfortunately this is incomplete - removing pagination leads to removing the indirection via results, but the frontend is not aware of this change, and so just about every page breaks with an exception when trying to access page.results.
(Even more unfortunately Playwright - or our testing approach - is not smart enough to recognize an exception is not the right behaviour, and instead Playwright spends the full timeout period waiting for something that will never appear. This is why E2E tests are timing out on this PR. The only good news is that when running the tests locally, this exception is visible in the Playwright trace viewer.)
sdemagny
force-pushed
the
sdem/remove_pagination
branch
from
7f3923a
to
dbb6fb8
Compare
For frontend pagination is useless for teams, so we remove it.
PanchoutNathan
force-pushed
the
sdem/remove_pagination
branch
from
dbb6fb8
to
c42b1f2
Compare
Morendil
approved these changes
Oct 30, 2024
In order to be in agreement with the back, we must modify the front so as to no longer have infinite scroll in the team part. It is also necessary to modify the tests accordingly
PanchoutNathan
force-pushed
the
sdem/remove_pagination
branch
from
96b887e
to
b46b0aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For frontend pagination is useless for teams,
so we remove it.
fixes #497