Skip to content

Social events/21 #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Social events/21 #414

wants to merge 5 commits into from

Conversation

ChehakTrehan
Copy link
Contributor

@ChehakTrehan ChehakTrehan commented Oct 7, 2025 •
edited
Loading

Fixex #21

Description of Changes

Related Issue

Type of Change

Please check the appropriate box that describes your PR:

  • 🐛 Bug Fix — Fixes a documented issue or incorrect behavior
  • ✨ Content Enhancement — Updates or improves existing content
  • ✍️ New Content — Adds new chapters, examples, or significant sections
  • 🛠️ Other — Please describe in the Description of Changes section

Additional Notes (Optional)

Checklist

@netlify Netlify
Copy link

netlify bot commented Oct 7, 2025 •
edited
Loading

✅ Deploy Preview for stupendous-kringle-a86e81 ready!

Name Link
🔨 Latest commit 4f21b5c
🔍 Latest deploy log https://app.netlify.com/projects/stupendous-kringle-a86e81/deploys/68ea1ef6d2f16f00080a4533
😎 Deploy Preview https://deploy-preview-414--stupendous-kringle-a86e81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ChehakTrehan
Copy link
Contributor Author

@aterrel @danielskatz Please review this PR.
Thanks
Chehak

@ChehakTrehan
Copy link
Contributor Author

@Oloni Please review this PR
Thanks
Chehak

aterrel
aterrel requested changes Oct 10, 2025
View reviewed changes
Copy link
Member

@aterrel aterrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, a few updates we would like to see.

.gitignore Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this file, or create another PR for it.

DISCOVER/11_inclusive_practices_during_checkin.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this deserves a new file, not an expanded section here.

Also please rank each recommendation with the rubric from the cookbook introduction (high impact, low impact, etc)

Don't repeat other sections of the cookbook like how to make food selections.

@ChehakTrehan
Copy link
Contributor Author

@aterrel I made the changes as suggested by you. Please review the PR #415
Thanks

@aterrel
Copy link
Member

aterrel commented Oct 12, 2025

Okay, it's best practice to commit files directly to the branch you are working on and not create a new PR. I do realize sometimes a PR is unsalvageable. Please close this one or move files here and close #415

@ChehakTrehan
Copy link
Contributor Author

@aterrel Got it! I’ll close this PR. Please do review PR #415.

@ChehakTrehan ChehakTrehan mentioned this pull request Oct 12, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aterrel aterrel aterrel requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChehakTrehan @aterrel