Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib/checks): import path of each check #55

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

steveej
Copy link
Contributor

@steveej steveej commented Jan 13, 2025

prior to this the values in the checks attrs weren't derivations.


marking as a draft as i'm still encountering an infinite recursion trying to use this.

the infinite recursion that i encountered is due to an intrinsic property of the module system, i.e. it's expected albeit not intuitive behavior. more in #56

prior to this the values in the checks attrs weren't derivations.
@steveej
Copy link
Contributor Author

steveej commented Jan 13, 2025

here's a log of the infinite recursion: https://buildbot-nix-0.infra.holochain.org/#/builders/440/builds/2

consumer code: https://github.com/Holo-Host/holo-host/pull/50/files#diff-1178a2379e02f5b2a29bb1227f783cf9d8fbe901e51f0924f3ccaddb02c1a565R15

the infinite recursion happens when the nixos test imports from flake.nixosModules.

@phaer i suspect the infinite recursion in the consumer is an issue of how i mapped the imports. is there something i could learn from 3da8b35?

@phaer
Copy link
Member

phaer commented Jan 13, 2025

@steveej Not sure, I am reading this correctly. The infinite recursion might not be directly related to this PR, correct? Don't see anything obvious at first glance, a more minimal reproducer which demonstrates the problem would be appreciated !

@steveej
Copy link
Contributor Author

steveej commented Jan 14, 2025

@phaer yes it's reproducible without the changes here. see: #56

@steveej steveej marked this pull request as ready for review January 14, 2025 20:01
this will respect `meta.platforms` and related attributes on a nixos
test derivation.
@matdibu
Copy link

matdibu commented Jan 17, 2025

I also just ran into this and I thought I was crazy

I've tested your PR and it seems to work

thank you for fixing this!

Copy link
Member

@phaer phaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phaer phaer merged commit 321795e into numtide:main Jan 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants