Skip to content

Fix test-driver output parsing crash on Ubuntu #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnoir merged 1 commit into from
Feb 19, 2025
Merged

Fix test-driver output parsing crash on Ubuntu #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/ubuntu.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,14 @@ in {
'';
}).sandboxed;

sudoSameConsole = (lib.ubuntu."23_04" {
sharedDirs = {};
testScript = ''
# Ensure using sudo doesn't crash the test-driver
vm.execute("sudo bash -c \"echo 'Created foo → bar.\n' >&2 && echo 'foo' \"")
'';
}).sandboxed;

}
// package.ubuntu.images
// runTestOnEveryImage multiUserTest
13 changes: 13 additions & 0 deletions ubuntu/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,19 @@ let
systemctl mask snapd.socket
systemctl mask snapd.seeded.service

# Disable TTY usage in sudo.
# Otherwise, using sudo spawns a new pty, causing the test-driver to
# receive mixed stdout and stderr when processing command output.
# The driver only expects base64-encoded stdout, so extra stderr data
# can break the output parsing.
mkdir -p /etc/sudoers.d
cat << EOF > /etc/sudoers.d/disable-pty
Defaults !requiretty
Defaults !use_pty
EOF
visudo -cf /etc/sudoers.d/disable-pty
chmod 440 /etc/sudoers.d/disable-pty

# We have no network in the test VMs, avoid an error on bootup
systemctl mask ssh.service
systemctl mask ssh.socket
Expand Down