Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forwarded cmd.exe commands docs #1613

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

Kissaki
Copy link
Contributor

@Kissaki Kissaki commented Nov 2, 2024

Replaces #1605 (which documented behavior across versions).

The "if no executable by that name exists" has been wrong since 0.94.0 (not disclosed in release notes, but consequence of 6c649809d38a687cd63b59ab028b7f30207e5663 PR 12921).

The "used to" (prior version 0.67 2022-08-16) is very old, and no longer worth it to keep.

Add information about forwarded commands overshadowing external files.

Replaces nushell#1605 (which documented behavior across versions).

The "if no executable by that name exists" has been wrong since 0.94.0 (not disclosed in release notes, but consequence of 6c649809d38a687cd63b59ab028b7f30207e5663).

The "used to" (prior version 0.67 2022-08-16) is very old, and no longer worth it to keep.

Add information about forwarded commands overshadowing external files.
book/coming_from_cmd.md Outdated Show resolved Hide resolved
book/coming_from_cmd.md Outdated Show resolved Hide resolved
book/coming_from_cmd.md Outdated Show resolved Hide resolved
book/coming_from_cmd.md Outdated Show resolved Hide resolved
* 'forwarded' -> 'internal'

Co-authored-by: Darren Schroeder <[email protected]>
@fdncred
Copy link
Collaborator

fdncred commented Nov 2, 2024

Thanks. Sorry for being so nit-picky with your changes.

@fdncred fdncred merged commit 75575c9 into nushell:main Nov 2, 2024
2 checks passed
@Kissaki
Copy link
Contributor Author

Kissaki commented Nov 3, 2024

No problem, I liked the suggested wording improvements. They're better wording.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants