Added partial completions to the MenuNext event#828
Merged
fdncred merged 2 commits intonushell:mainfrom Sep 24, 2024
Merged
Conversation
Contributor
|
Thanks! |
Contributor
|
I believe this is the cause of nushell #14152, or there're deeper bugs in the |
Contributor
Author
|
This seems to be a very similar same issue to #833 . The problem seems to be caused by IdeMenu's implementation of |
This was referenced Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to address a nushell specific issue (nushell/nushell#11251) about the tab button not partially completing suggestions if the menu is already open. I added partial completions to the MenuNext event after checking if they were enabled.