made can_partially_complete() only complete when suggesting more than the input

[uek-1]

Addresses #833 . menu.can_partially_complete() would reset the current selection 0 and return true even if the suggested partial completion was exactly the same. Changed can_partially_complete in menu_functions to return false and not complete if the suggested partial completion is the exact same as the input.

[fdncred]

I'm trying to test this but can't get it to work. Here's what I did.

cargo run --example demo
a<tab><tab><tab>

I can't get any of the tabs to progress. I figure I'm doing something wrong. Please let me know.

Strangely enough, shift-tab will go backwards through all the items, but tab won't go forwards through them.

[uek-1]

I think this might be an issue with the demo itself. Tabs don't seem to progress as of d8b240a either. Looking at the code, I see that MenuNext is actually not bound to tab in the demo (binding it does fix issue).

reedline/examples/demo.rs

Lines 244 to 250 in 660a507

	keybindings.add_binding(
	KeyModifiers::NONE,
	KeyCode::Tab,
	ReedlineEvent::UntilFound(vec![
	ReedlineEvent::Menu("completion_menu".to_string()),
	ReedlineEvent::Edit(vec![EditCommand::Complete]),
	]),

[fdncred]

Can you submit a PR for that fix to the demo.rs app too please, in a separate PR? This makes total sense.

[132ikl]

Is there anything blocking this PR?

[fdncred]

nope. i was hoping to get more eyes on it but doesn't look like anyone is objecting.