Skip to content

Conversation

AnandajithS
Copy link

The default left and right prompt colors were set as Green and AnsiValue(5) respectively, which caused the prompt to be colored even when it was reset. This fix makes the prompts respect the terminal default colors when style="none"

Fixes nushell/nushell#16384

@fdncred
Copy link
Contributor

fdncred commented Sep 17, 2025

Thanks. The only problem I see here is that neither the left nor right prompt has default colors any longer.

Before

image

After

image

@AnandajithS
Copy link
Author

Apologies for the delay in following up.and thank you for the feedback. In this fix, the prompts will take on the default colors of the terminal when style="none". The colors can still be changed either by applying a style or by adjusting the terminal settings as needed. If this is acceptable, could it be merged?

@fdncred
Copy link
Contributor

fdncred commented Oct 16, 2025

I'm not sure because it changes the default colors of the reedline prompts except for the indicator. How do we maintain the colors but not bleed over?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text has ANSI styling (no reset) before prompt is printed

2 participants