Skip to content

Add ReedlineEvent::SubmitOrSpace #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add ReedlineEvent::SubmitOrSpace #965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6195ae5
add ReedlineEvent::SubmitOrSpace
zknx Oct 24, 2025
b756b84
refactor: drop explicit `return`
zknx Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,7 +880,8 @@ impl Reedline {
ReedlineEvent::Enter
| ReedlineEvent::HistoryHintComplete
| ReedlineEvent::Submit
| ReedlineEvent::SubmitOrNewline => {
| ReedlineEvent::SubmitOrNewline
| ReedlineEvent::SubmitOrSpace => {
if let Some(string) = self.history_cursor.string_at_cursor() {
self.editor
.set_buffer(string, UndoBehavior::CreateUndoPoint);
Expand Down Expand Up @@ -1170,6 +1171,20 @@ impl Reedline {
}
}
}
ReedlineEvent::SubmitOrSpace => {
#[cfg(feature = "bashisms")]
if let Some(event) = self.parse_bang_command() {
return self.handle_editor_event(prompt, event);
}
for menu in self.menus.iter_mut() {
if menu.is_active() {
menu.replace_in_buffer(&mut self.editor);
menu.menu_event(MenuEvent::Deactivate);
}
}
self.run_edit_commands(&[EditCommand::InsertChar(' ')]);
Ok(EventStatus::Handled)
}
ReedlineEvent::ExecuteHostCommand(host_command) => {
self.suspended_state = Some(self.painter.state_before_suspension());
Ok(EventStatus::Exits(Signal::Success(host_command)))
Expand Down
4 changes: 4 additions & 0 deletions src/enums.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,6 +755,9 @@ pub enum ReedlineEvent {
/// Submit at the end of the *complete* text, otherwise newline
SubmitOrNewline,

/// Submit at the end of the *complete* text, otherwise space
SubmitOrSpace,

/// Esc event
Esc,

Expand Down Expand Up @@ -848,6 +851,7 @@ impl Display for ReedlineEvent {
ReedlineEvent::Enter => write!(f, "Enter"),
ReedlineEvent::Submit => write!(f, "Submit"),
ReedlineEvent::SubmitOrNewline => write!(f, "SubmitOrNewline"),
ReedlineEvent::SubmitOrSpace => write!(f, "SubmitOrSpace"),
ReedlineEvent::Esc => write!(f, "Esc"),
ReedlineEvent::Mouse => write!(f, "Mouse"),
ReedlineEvent::Resize(_, _) => write!(f, "Resize <int> <int>"),
Expand Down