fix: wrong answer of find_common_string
#969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blindFS
commented
Oct 25, 2025
Comment on lines
-184
to
-187
| lhs.make_ascii_lowercase(); | ||
| rhs.make_ascii_lowercase(); | ||
|
|
||
| lhs != rhs |
Contributor
Author
There was a problem hiding this comment.
I think this should be case sensitive, correct me if I'm wrong.
blindFS
commented
Oct 25, 2025
Comment on lines
348
to
353
| let entered_input = &editor.get_buffer()[start..end]; | ||
| let extends_input = matching | ||
| .to_ascii_lowercase() | ||
| .contains(&entered_input.to_ascii_lowercase()) | ||
| && matching != entered_input; |
Contributor
Author
There was a problem hiding this comment.
And this should be case insensitive...
sholderbach
reviewed
Nov 5, 2025
blindFS
force-pushed
the
fix_find_common_prefix
branch
from
25f01b1 to
3d9f5e2
Compare
Contributor
Author
|
@ysthakur Would you please take a look at this when you get time? |
ysthakur
reviewed
Nov 11, 2025
Member
ysthakur
left a comment
ysthakur
left a comment
There was a problem hiding this comment.
Thanks, LGTM, just need a couple more test cases
Member
There was a problem hiding this comment.
Unrelated to this PR, but we should make a .gitattributes and add this as a generated file in there, not sure how we haven't done that until now
blindFS
commented
Nov 11, 2025
blindFS
commented
Nov 11, 2025
ysthakur
approved these changes
Nov 13, 2025
Member
ysthakur
left a comment
ysthakur
left a comment
There was a problem hiding this comment.
LGTM. The new unicase dependency only adds 23.5 KiB, which I think is acceptable
ysthakur
added
A-Completions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug described here.
Update:
Fixes nushell/nushell#15535