fix: Make ColumnarMenu suggestions always take 1 line #973
+138
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysthakur
commented
Nov 17, 2025
src/menu/menu_functions.rs
Outdated
| /// | ||
| /// If `s` is longer than `max_width`, the resulting string will end in "..." | ||
| /// and have width at most `max_width`. | ||
| pub(crate) fn truncate_no_ansi(s: &str, max_width: usize) -> Cow<str> { |
Member
Author
There was a problem hiding this comment.
It's named truncate_no_ansi because I intend to add a truncate_with_ansi helper that truncates strings that do contain ANSI escapes (so it must ignore the ANSI escapes)
ysthakur
commented
Nov 17, 2025
| } else { | ||
| suggestion.value.clone() | ||
| }; | ||
| let string = truncate_no_ansi(&suggestion.value, max_string_width); |
Member
Author
There was a problem hiding this comment.
I used the truncation helper here because the original code looks at number of chars rather than width
Contributor
|
Nice! Works well for me. |
Contributor
|
A separated minor issue of IDE menu: The display is a bit off on some cherry-picked terminal width values, on the edge of showing/hiding the description window. |
ysthakur
commented
Nov 17, 2025
| if let Ok(position) = cursor::position() { | ||
| self.prompt_start_row = position.1; | ||
| self.just_resized = true; | ||
| #[cfg(not(test))] |
Member
Author
There was a problem hiding this comment.
Couldn't figure how to mock the Painter struct with mockall so I figured this was easier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #972
Description
When the longest suggestion in a columnar menu exceeds the screen width, all suggestions will take up more than 1 line. None of the suggestion values will be truncated, and even short suggestion values will be padded to the same length as the longest suggestion. This PR fixes that by truncating values to the screen width.
This PR is just a fix, so I didn't want to change behavior too much, but in the future, we might want to consider basing the padding not on the longest suggestion, but the longest visible suggestion (when there are descriptions). When there aren't descriptions, the number of columns would probably have to be based on the longest suggestion overall, since it might be confusing if you scroll down and the number of columns changes.
Screenshots
Here's an example of how the values get truncated (note that these suggestions have descriptions, they're just not shown because the longest suggestion is too long):
When the longest suggestion isn't too long, you see the descriptions (in this PR, I changed it so that they end in
"..."when truncated):And this is what you get without descriptions:
