Toggleable left to right prerequisites trees #3842
Open
+756
−293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quisite/dependent tree
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@zehata is attempting to deploy a commit to the modsbot's projects Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3842 +/- ##
==========================================
+ Coverage 53.87% 54.76% +0.89%
==========================================
Files 274 275 +1
Lines 6032 6080 +48
Branches 1449 1461 +12
==========================================
+ Hits 3250 3330 +80
+ Misses 2782 2750 -32 ☔ View full report in Codecov by Sentry. |
zehata
changed the title
|
bd7c8aa is technically outside the scope of this PR, but if it makes codecov happy then so be it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #3202 Prerequisite tree right-to-left progression is confusing
Implementation
This PR extends PR #3840's implementation and adds a toggle for the user to choose whether they prefer the prerequisite to appear on the left or the right. Setting defaults to prerequisites on the left, which is the requested specifications for #3202. Please note that this branch diverges from the branch in PR #3840 and cannot both be merged.
While Issue #3203 specifications does not ask for ability to toggle, some users like myself may have already gotten used to prerequisites on the right. However, I do agree that the prerequisites on the right seems to be more intuitive.
I also took the chance to fix some confusing naming in the code, like the trees having class names that were opposite of what they contained. The fix for the truncation bug in PR #3840 is also carried over.
Credits to @sciffany for copywriting and initial implementation, to @li-kai for implementation feedback and to @alvynben for implementation and test cases.
UI tests
Settings toggle:
Single prerequisite/dependents:
Left
Right, i.e. original layout (unchanged)
Complex prerequisite/dependents with uneven layers and uneven letters in module codes
Left
Prefixed prerequisites
Side effect fixes:
This also fixes misaligned module trees as a side effect
Other Information
Any questions you may have
Is there a tele group specific for development?
Letting us know that you're new to this (so we know how much to help out)
Again, been almost 3 years since I touched any web dev. Sorry in advance if I had missed out anything.