add-port-testing-module #31
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will give this a look asap. |
wolffberg
suggested changes
Jul 15, 2020
| chart_version = var.chart_version | ||
| release_name = "port-tester" | ||
| repository = "https://harbor.aws.c.dk/chartrepo/shared-platforms" | ||
| create_namespace = true |
There was a problem hiding this comment.
This should be removed as it's replaced by kubernetes_namespace.this
Suggested change
| create_namespace = true |
…t openings to knet are still active
anarsen
force-pushed
the
add-port-testing-module
branch
from
fac299f
to
9532e6d
Compare
|
Seems like the @eamonnmoloney Let's sit down when you're back and get you set up with access to ECR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the port testing module. This installs a simple server that dashboards can poll to confirm port openings on the internal firewall