-
Notifications
You must be signed in to change notification settings - Fork 4
feat: discord notifications #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some minor improvements could be made but not required.
I see shoutrrr in the go.mod 😉 I wasted a lot of time going down that road and trying to implement it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just unsure if DiscordSender should be exported or not. If it runs then it shouldn't be needed 😄
@@ -49,15 +49,15 @@ const ( | |||
GRAY EmbedColors = 10070709 // 99aab5 | |||
) | |||
|
|||
type DiscordSender struct { | |||
type discordSender struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this still needs to be exported no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's only used in the notification module so should be fine like this 😄
d43893f
to
552c85b
Compare
any control over what is sent or just sends all currently? |
This implements discord notifications for all the important events. I'm planning to implement more notification services but discord should be enough for now.
Resolves #114