fix(schemes): OAuth2 URL may already contain query params#1832
Open
ekkekuru2 wants to merge 1 commit intonuxt-community:devfrom
Open
fix(schemes): OAuth2 URL may already contain query params#1832ekkekuru2 wants to merge 1 commit intonuxt-community:devfrom
ekkekuru2 wants to merge 1 commit intonuxt-community:devfrom
Conversation
|
When will this be merged? |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
This is my first Pull Request, so sorry if there are some problem.
I have fixed a problem which occurs when OAuth2 authorization endpoint URL contains '?'.
If OAuth2 authorization endpoint URL contains '?' (=already has query params), this module will join options generated by this module to given URL with '&' ,not '?'.
Issue is here #1831
Thanks for the confirmation.