Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RadioGroup): add card and table variants #3178

Open
wants to merge 8 commits into
base: v3
Choose a base branch
from
Open

Conversation

romhml
Copy link
Collaborator

@romhml romhml commented Jan 26, 2025

πŸ”— Linked issue

Resolves #2932

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Introduces two new card and table variants on the RadioGroup component.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

cloudflare-workers-and-pages bot commented Jan 26, 2025

Deploying ui3 with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: 8798fdb
Status:Β βœ…Β  Deploy successful!
Preview URL: https://91e35ff4.ui-6q2.pages.dev
Branch Preview URL: https://feat-radio-card.ui-6q2.pages.dev

View logs

Copy link

pkg-pr-new bot commented Jan 26, 2025

npm i https://pkg.pr.new/@nuxt/ui@3178

commit: e1b06b0

@HugoRCD HugoRCD mentioned this pull request Jan 29, 2025
Closed
28 tasks
@benjamincanac benjamincanac added the v3 #1289 label Jan 30, 2025
@romhml romhml changed the title feat(RadioGroup): add card variant feat(RadioGroup): add card and table variant Feb 1, 2025
@romhml romhml changed the title feat(RadioGroup): add card and table variant feat(RadioGroup): add card and table variants Feb 1, 2025
@romhml romhml marked this pull request as ready for review February 1, 2025 09:21
@romhml romhml requested a review from benjamincanac February 1, 2025 09:22
@romhml romhml self-assigned this Feb 1, 2025
@benjamincanac benjamincanac force-pushed the v3 branch 2 times, most recently from aa74a4f to 87234cb Compare February 4, 2025 15:31
@Deeyuude
Copy link

Any updates on this one please ?
Thank you

@Deeyuude
Copy link

Deeyuude commented Mar 1, 2025

Really needed please ☺

@romhml
Copy link
Collaborator Author

romhml commented Mar 1, 2025

@Deeyuude I'll try to get back into it soon!

@simonmaass
Copy link

yeah this would be great

@joris-paqt
Copy link

This would be awesome!

@romhml
Copy link
Collaborator Author

romhml commented Mar 14, 2025

@benjamincanac this is ready for review.

Copy link
Contributor

nuxthub-admin bot commented Mar 14, 2025

βœ… Deployed ui3

Deployed ui3 e1b06b0 to preview

πŸ”— feat-radio-card.ui-6q2.pages.dev
πŸ“Œ 388d427e.ui-6q2.pages.dev
πŸ“±
View QR Code QR code linking to deployment URL.

πŸ“‹ View deployment logs

@Deeyuude
Copy link

Deeyuude commented Mar 15, 2025

Thank you for your great work @romhml just a quick question ! Don't you think that the card variant could have an icon beside the label & description ? Like the image in linked issue i mean

@simonmaass
Copy link

Thank you for your great work @romhml just a quick question ! Don't you think that the card variant could have an icon beside the label & description ? Like the image in linked issue i mean

that would be great!

@romhml
Copy link
Collaborator Author

romhml commented Mar 15, 2025

@Deeyuude you'll be able to do something similar using the label slot:

<URadioGroup :variant="variant" :items="items">
  <template #label="{ item }">
    <UIcon :name="item.icon" />
    <span>
      {{ item.label }}
    </span>
  </template>
</URadioGroup>

I don't know if it is a good idea to add something like this by default since it is not generalizable to all variants.

@simonmaass
Copy link

I don't know if it is a good idea to add something like this by default since it is not generalizable to all variants.

Thats a good point!

@Kiansa
Copy link

Kiansa commented Mar 17, 2025

Great work @romhml ! it looks and feels very nice!
It’d be awesome to add a card-style variant to the USelect component (or create a standalone USelectCard) for multi-selection use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RadioCard Component
6 participants