Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SelectMenu): add clearable icon to reset modelValue #3244

Open
wants to merge 9 commits into
base: v3
Choose a base branch
from
Open

feat(SelectMenu): add clearable icon to reset modelValue #3244

wants to merge 9 commits into from
+126 −59

Conversation

emilsgulbis
Copy link

🔗 Linked issue

#1057

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Added clear button to the SelectMenu

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Sorry, something went wrong.

@benjamincanac benjamincanac added the v3 #1289 label Feb 5, 2025
@emilsgulbis
Copy link
Author

hey @benjamincanac
tried my best for first time OS PR. If i need to make any adjustments - please let me know

@emilsgulbis
Copy link
Author

@benjamincanac Could you please give me some instructions to make this good to merge?

@rasyidly
Copy link

up, i really need this feature 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v3 #1289
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emilsgulbis @rasyidly @benjamincanac