-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): improve generic types #3331
Open
sandros94
wants to merge
109
commits into
v3
Choose a base branch
from
refactor-types
base: v3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #2140
Also discussed privately and https://github.com/nuxt/ui-pro/pull/753#issuecomment-2625295701
β Type of change
π Description
The main goal for this PR is to both simplify the use of types as well as properly document them for each component that might use them.
Notes
Carousel
, because the inferredstring[]
is more than enough.CommandPalette
([CommandPalette] Generics not working well with items inside groupsΒ #2260) will require additional work in separate PR. Similarly for named slots within children (for those components that do support it), as they might require a similar approach.Breadcrumb
have alabelKey?: string
that I was looking for changing with proper typing, but for some reason they all break the forwarding of propsπ Components Checklist
As this PR touches basically almost all components here is a brief description on what changed for what component.
Legend
*
: means that I might need an additional verification before mergeComponents
Accordion
: docs, generics (ui-pro typecheck error, as expected)Breadcrumb
: docs, genericsButtonGroup
: examplesCalendar
: genericsCarousel
: genericsCommandPalette
: probably will be covered in different PRContextMenu
: docs, generics, dynamicsDropdownMenu
: docs, generics, dynamicsForm
: examplesInputMenu
: examples, generics, dynamicsNavigationMenu
: docs, generics, dynamicsRadioGroup
: docs, generics *Select
: examples, generics, dynamicsSelectMenu
: examples, generics, dynamicsStepper
: docs, genericsTable
: probably will be covered in different PRTabs
: docs, generics