fix: add setTimeout to ensure element receives focus #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wrap focus and scrollIntoView calls in a setTimeout with 0ms delay. - This allows the browser to complete its render cycle before applying focus. - Fixes issue where the input field was found but not focused.
commit: |
romhml
reviewed
Mar 18, 2025
| @@ -22,8 +22,10 @@ async function onSubmit(event: FormSubmitEvent<any>) { | |||
| async function onError(event: FormErrorEvent) { | |||
| if (event?.errors?.[0]?.id) { | |||
| const element = document.getElementById(event.errors[0].id) | |||
| element?.focus() | |||
| element?.scrollIntoView({ behavior: 'smooth', block: 'center' }) | |||
| setTimeout(() => { | |||
There was a problem hiding this comment.
This feels a bit hacky, can we use nextTick instead?
There was a problem hiding this comment.
This feels a bit hacky, can we use
nextTickinstead?
indeed, as the main thread could be put on hold by the browser/OS while setTimeout run just fine in another thread taking us nowhere 😕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
📝 Checklist