-
Notifications
You must be signed in to change notification settings - Fork 765
fix(Table): update styles for thead and th elements to show border fr… #4083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3
Are you sure you want to change the base?
Conversation
…om thead at the correct position in safari
I see the issue on Safari, however your solution doesn't really fix the issue as it breaks the border on Chrome with sticky header. The sticky head was the reason I used |
Uh I didn't checked with sticky header. I don't really get behind what Safari wants that it is displaying the pseudo element correct. I can see if I can find a other solution to fix it for Safari. |
I've figured out how it works with the pseudo after in safari and chrome. Instead of after:bottom-0 using after:end-full is doing it correctly. |
It seems it does break the |
Introduces a dedicated row for the table head underline to enable more flexible and maintainable header border styling. Refactors related theme classes to support this separation and resolves z-index layering for loading state visuals.
I’ve explored several CSS-based approaches to solve this issue, but unfortunately, Safari doesn’t respect the height of One workaround I attempted was to read the height of As a more robust alternative, I added an actual |
…om thead at the correct position in safari
Resolves #4180
❓ Type of change
📚 Description
This is my first PR! Sorry if there is something wrong. I've noticed today that the border in the table header move to the end of the table in Safari. Tried to fix it with still using the after pseudo element but I had no luck. Now we're not using the after element at all. The calculation in th is that the content doesn't get shifted by the border. You shouldn't notice any change in Chrome but this fixes the bug in Safari
📝 Checklist