Skip to content

fix(Form): expose reactive fields #4386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 24, 2025
Merged

fix(Form): expose reactive fields #4386

merged 5 commits into from
Jun 24, 2025

Conversation

Bobakanoosh
Copy link
Contributor

@Bobakanoosh Bobakanoosh commented Jun 23, 2025 •
edited
Loading

🔗 Linked issue

Resolves #4238

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  • Wrapped dirtyFields, touchedFields, and blurredFields in ref
  • Returned a computed instead of a readonly of the given fields as it's effectively the same but much simpler types
  • Fixed previously broken test cases that falsely tested reactivity of these fields. These changes can be validated by running the new tests with the old version of the component and seeing they change.
  • Added test case for dirtyFields and dirty

Wasn't sure if a type change counts as a breaking change which is why I have both checked.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Bobakanoosh
fix(Form): exposed dirty, dirtyFields, blurredFields, and touchedFiel…
a8c64d1 
…ds not reactive

chore(Form): revert unintended code style changes

chore: remove unintended settings.json creation

fix(Form): update broken tests

chore(Form): remove unintended code style changes

chore: remove unintended settings.json creation

chore(Form): fix linter issues

chore(Form): fix eslint error
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 23, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@4386

commit: 9a97265

@benjamincanac benjamincanac requested a review from romhml June 23, 2025 09:30
romhml
romhml reviewed Jun 23, 2025
View reviewed changes
romhml
romhml approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@romhml romhml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bobakanoosh :)

@benjamincanac benjamincanac changed the title fix(Form): exposed dirty, dirtyFields, blurredFields, and touchedFiel… fix(Form): expose reactive fields Jun 24, 2025
@benjamincanac benjamincanac merged commit 1a8feb7 into nuxt:v3 Jun 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romhml romhml romhml approved these changes

@benjamincanac benjamincanac Awaiting requested review from benjamincanac benjamincanac is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form exposed dirty, dirtyFields, blurredFields, and touchedFields are not reactive
3 participants
@Bobakanoosh @romhml @benjamincanac