Skip to content

fix(Table): add scope attribute to headers #4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2025
Merged

fix(Table): add scope attribute to headers #4417

merged 3 commits into from
Jun 30, 2025

Conversation

J-Michalek
Copy link
Collaborator

@J-Michalek J-Michalek commented Jun 28, 2025 •
edited by benjamincanac
Loading

🔗 Linked issue

Resolves: #4410

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I have added the scope attribute to the th elements of the table improving accessibility for screen readers.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 28, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@4417

commit: 32c5889

@J-Michalek J-Michalek marked this pull request as draft June 28, 2025 13:14
@J-Michalek J-Michalek marked this pull request as ready for review June 28, 2025 13:19
@J-Michalek J-Michalek marked this pull request as draft June 29, 2025 05:10
@J-Michalek
fix(Table): use proper values for scope attribute
32c5889 
For some reason I though we were supposed to provide
the value which the column represents but that is not the case
it accepts a predefined set of values such as col, colgroup etc.
@J-Michalek J-Michalek marked this pull request as ready for review June 29, 2025 05:18
@benjamincanac benjamincanac changed the title feat(Table): add scope attribute to table headers feat(Table): add scope attribute to headers Jun 30, 2025
@benjamincanac benjamincanac changed the title feat(Table): add scope attribute to headers fix(Table): add scope attribute to headers Jun 30, 2025
@benjamincanac benjamincanac merged commit 347694b into nuxt:v3 Jun 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UTable Accessibility for screen readers (th scope)
2 participants
@J-Michalek @benjamincanac