Skip to content

Fix cuda paths for non-default cuda locations #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: branch-24.03
Choose a base branch
from
Open

Fix cuda paths for non-default cuda locations #665

wants to merge 2 commits into from

Conversation

@jjwilke
Copy link
Contributor

@jjwilke jjwilke commented Apr 5, 2023

Addresses issue #662

  • Validates that nvcc exists at specified cuda location
  • Explicitly sets CMAKE_CUDA_COMPILER
  • Forwards appropriate variables to Legion as ENV(CUDA_BIN_PATH)
  • Validates that Legion and Legate found the same CUDA

@jjwilke jjwilke requested a review from trxcllnt April 5, 2023 17:38
@trxcllnt trxcllnt added the category:bug-fix PR is a bug fix and will be classified as such in release notes label Apr 5, 2023
@marcinz marcinz changed the base branch from branch-23.05 to branch-23.07 May 18, 2023 20:14
@marcinz marcinz changed the base branch from branch-23.07 to branch-23.09 July 18, 2023 15:39
@marcinz marcinz changed the base branch from branch-23.09 to branch-23.11 September 26, 2023 00:23
@marcinz marcinz changed the base branch from branch-23.11 to branch-24.01 November 9, 2023 16:52
@marcinz marcinz changed the base branch from branch-24.01 to branch-24.03 February 22, 2024 00:54
manopapad pushed a commit that referenced this pull request Mar 5, 2025
@marcinz
Do not install cuda-toolkit (#665)
a63a2a8 
cuda-toolkit pulls a lot of dependencies. The environment we generate should match our needs, and if the users want to, they can install the full cuda-toolkit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

Assignees

No one assigned

Labels

category:bug-fix PR is a bug fix and will be classified as such in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jjwilke @trxcllnt