Skip to content

Setting up pre-commit #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

RyanMcCleary
Copy link

This PR includes the following changes:

  • The files .pre-commit-config.yaml and pyproject.toml were added. The structure of these files is kept close to that found in the corresponding files from the main NVDA repository, with some configurations removed that are not applicable to this repository.
  • The JSON configuration file for pyright was removed, since pyright configuration is now being handled by pyproject.toml.
  • The option reportMissingImports was temporarily set to false, since it was triggering pyright errors.
  • Some unnecessary noqa comments were removed, and one was added to suppress a pyright error caused by the scriptHandler.script decorator.
  • Whitespace was removed from the ends of lines, CRLF was converted to LF, and other minor formatting changes were carried out by running ruff-format.

Note: To run the pre-commit checks, install pyright, ruff, and pre-commit in a virtual environment first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant