Skip to content

chore!: Dotnet 8 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

chore!: Dotnet 8 #38

merged 1 commit into from
Apr 2, 2025

Conversation

Soap-141
Copy link
Contributor

@Soap-141 Soap-141 commented Apr 2, 2025

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

What is the current behavior?

Projects in the solution target .NET 6-7 and C# 10-11.

What is the new behavior?

Projects in the solution target .NET 8 and C# 12.

Impact on version

  • Major (Public API was modified.)
    • Public constructs (class, struct, delegate, enum, etc.) were removed or renamed.
    • Public members were removed or renamed.
    • Public method signatures were changed or renamed.
  • Minor (Public API was extended.)
    • Public constructs, members, or overloads were added.
  • Patch (Public API was unchanged.)
    • A bug in behavior was fixed.
    • Documentation was changed.
  • None (The library is unchanged.)
    • Only code under the build folder was changed.
    • Only code under the .github folder was changed.

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.
  • Automated Unit / Integration tests for the changes have been added/updated.
  • Updated BREAKING_CHANGES.md (if you introduced a breaking change).
  • Your conventional commit are aligned with the Impact on version section.

Other information

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the solution's target framework to .NET 8 and adjusts related build configuration and documentation accordingly.

  • Updated DotNetVersion, UnoCheck_Version, and UnoCheck_Manifest in build/stage-build.yml for .NET 8 support.
  • Added breaking changes notes in BREAKING_CHANGES.md indicating support for .NET 8 and removal of .NET 7.

Reviewed Changes

Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.

File Description
build/stage-build.yml Updated build configuration for .NET 8 support.
BREAKING_CHANGES.md Documented breaking changes for framework upgrade.
Files not reviewed (5)
  • src/BackButtonManager.Abstractions/BackButtonManager.Abstractions.csproj: Language not supported
  • src/BackButtonManager.Tests/BackButtonManager.Tests.csproj: Language not supported
  • src/BackButtonManager.Uno.WinUI/BackButtonManager.Uno.WinUI.csproj: Language not supported
  • src/BackButtonManager.Uno.WinUI/winappsdk-workaround.targets: Language not supported
  • src/BackButtonManager/BackButtonManager.csproj: Language not supported

@Soap-141 Soap-141 force-pushed the dev/thla/chore-dotnet8 branch from 882a5e8 to 62a1de9 Compare April 2, 2025 13:56
@Soap-141 Soap-141 force-pushed the dev/thla/chore-dotnet8 branch from ba5c63d to f6e4a75 Compare April 2, 2025 15:30
@Soap-141 Soap-141 merged commit c035701 into main Apr 2, 2025
3 checks passed
@Soap-141 Soap-141 deleted the dev/thla/chore-dotnet8 branch April 2, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants