Skip to content

fix: Android Bottom Screen Space #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Conversation

Soap-141
Copy link
Contributor

@Soap-141 Soap-141 commented May 30, 2025

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

Fixed the weird space at the bottom of the screen.

Before.
image

After.
image

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and TemplateConfig.md if you made changes to templating.
    • Update AzurePipelines.md and APP_README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@Soap-141 Soap-141 force-pushed the dev/thla/fix-android-bottom-space branch from ea02b17 to 58d5fc2 Compare May 30, 2025 15:44
@Soap-141 Soap-141 marked this pull request as ready for review May 30, 2025 15:46
@Soap-141 Soap-141 requested review from jeanplevesque, Copilot and a team and removed request for jeanplevesque May 30, 2025 15:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the unwanted bottom gap on Android by making the activity resizable and updating documentation.

  • Enabled ResizeableActivity to allow the layout to fill the screen.
  • Added context comment in AndroidManifest.xml about the resizable requirement.
  • Updated CHANGELOG.md to document the patch.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/app/ApplicationTemplate.Mobile/Android/MainActivity.Android.cs Changed ResizeableActivity from false to true.
src/app/ApplicationTemplate.Mobile/Android/AndroidManifest.xml Added comment about requiring a resizable activity.
CHANGELOG.md Added entry for the Android bottom screen space fix.

@Soap-141 Soap-141 merged commit f3389b2 into main May 30, 2025
14 checks passed
@Soap-141 Soap-141 deleted the dev/thla/fix-android-bottom-space branch May 30, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants