Skip to content

Conversation

wroyca
Copy link
Contributor

@wroyca wroyca commented Sep 9, 2024

Add 'nvim-bqf' explicit highlight groups to mini.hues.

Before:

image

After:

image

@wroyca wroyca changed the title feat(mini.hues): 'nvim-bqf' explicit highlight groups. feat(hues): 'nvim-bqf' explicit highlight groups. Sep 9, 2024
@wroyca wroyca changed the title feat(hues): 'nvim-bqf' explicit highlight groups. feat(hues): 'nvim-bqf' explicit highlight groups Sep 9, 2024
@pkazmier
Copy link
Member

This might motivate our beloved plugin author to start on his quickfix module sooner than later. Okay, I admit that was really just my wishful thinking. The other day he stated that it was likely going to be the snippet module next.

In the meantime, I was planning on evaluating a quickfix plugin. Currently looking at stevearc's quicker, but will add this to my list too.

@echasnovski
Copy link
Member

Thanks for the PR!

All integrations apart from 'mini.nvim' modules have only necessary (that need to be different from their default links/definitions) highlight groups defined. Only three seem to be problematic here, which are now set on latest main. Same was for 'mini.base16'.

This might motivate our beloved plugin author to start on his quickfix module sooner than later. Okay, I admit that was really just my wishful thinking. The other day he stated that it was likely going to be the snippet module next.

In the meantime, I was planning on evaluating a quickfix plugin. Currently looking at stevearc's quicker, but will add this to my list too.

Yes, 'mini.snippets' has top priority right now. I don't think 'mini.quickfix' is top-3 yet, but I'd like to take a look sometime at how quickfix lists can be made better. After a brief testing of 'nvim-bqf' for this PR, I can't say I like the preview window workflow (not sure why, though). Will need to do a separate research on that.

@wroyca
Copy link
Contributor Author

wroyca commented Sep 10, 2024

All integrations apart from 'mini.nvim' modules have only necessary (that need to be different from their default links/definitions) highlight groups defined. Only three seem to be problematic here, which are now set on latest main. Same was for 'mini.base16'.

Thanks! I was not sure if I had to put all the highlight groups or just the problematic ones, so I opted to put them all for completeness' sake, not knowing that the latter was preferred. :)

@wroyca
Copy link
Contributor Author

wroyca commented Sep 10, 2024

After a brief testing of 'nvim-bqf' for this PR, I can't say I like the preview window workflow (not sure why, though). Will need to do a separate research on that.

Ah! Funny that you mention it. I also feel slightly uncomfortable with the preview window, but at the same time, I don't know what "comfortable" would be like. Do share your thoughts if any!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants