fix(highlights): preview may (rarely) show wrong highlight #3305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a minor bug in the builtin highlights picker where having `Comment` selected in the picker shows `SpecialComment` in the previewer. Only happens when the selected highlight is a suffix of another highlight and the other highlight occurs first.
jamestrew
added
the
backport-0.1.x
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the builtin highlights picker where the selected highlight won't be displayed in the previewer if the selected highlight is a suffix of another highlight and that other highlight occurs first in the list of highlights. For example, having
Commentselected in the picker showsSpecialCommentin the previewer. Another example is 'Cursor'/'TermCursor'The fix is trivial, just match at the start of the line (in addition to requiring a space after)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration
:Telescope highlightsand search forComment. Expected:Commentis shown in the preview. Actual:SpecialCommentis shownConfiguration:
Neovim version (nvim --version):
NVIM v0.10.1
Build type: Release
LuaJIT 2.1.1720049189
Operating system and version:
Darwin astrotop.local 23.6.0 Darwin Kernel Version 23.6.0: Fri Jul 5 17:54:20 PDT 2024; root:xnu-10063.141.1~2/RELEASE_X86_64 x86_64
Checklist: