fix(previewer): preview=false option inheritance
#3327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
According to `:h telescope.defaults.preview`, we should be able to do
`preview=false` to disable the previewer for pickers. With how picker
options resolve inheritance, something like this should work.
```lua
require('telescope').setup {
defaults = { preview = true },
pickers = { find_files = { preview = false } }
}
```
Here, find_files should not show a previewer but it previously would.
Corrects this by checking if `opts.preview` is explicitly set to
`false`. In which case, we won't show the previewer.
Closes nvim-telescope#3325
Conni2461
force-pushed
the
preview-opt-inheritance
branch
from
ed7972e to
f745b61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
:h telescope.defaults.preview, we should be able to dopreview=falseto disable the previewer for pickers. With how picker options resolve inheritance, something like this should work.Here, find_files should not show a previewer but it previously would.
Corrects this by checking if
opts.previewis explicitly set tofalse. In which case, we won't show the previewer.Closes #3325