fix(builtin): avoid duplicate LSP reference results #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of multiple LSP servers, making a request to each server can result in similar results. For example: If both typescript & angular language server are running and request "textDocument/references" is executed, results from 2 servers are overlapping, resulting in telescope showing duplicate list of results. Fix is to check if resulting table (`items`) contains similar item and don't add it.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi! Thanks for the great neovim plugin!
I have a small (but unpleasant) problem.
In case of multiple LSP servers, making a request to each server can result in similar results.
For example:
In angular project, if both typescript & angular language server are setup and running, execution of "textDocument/references" resulting in telescope showing duplicate list of results.
Fix is to check if resulting table (
items) contains similar item and don't add it.I have small experience in Lua, so there's probably some improvements to be made to this fix.
Fixes # (issue) (haven't found any relevant issues)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested locally, with various combinations of LSP servers/languages.
Configuration:
Checklist: