Skip to content

Conversation

dustypomerleau
Copy link
Contributor

@dustypomerleau dustypomerleau commented Feb 19, 2025

Description

neovim/neovim#30860 introduced the position_encoding parameter in symbols_to_items(). This breaks :Telescope lsp_document_symbols, lsp_workspace_symbols, and lsp_dynamic_workspace_symbols for anyone running nightly Neovim.

Type of change

EDIT: draft status removed. Should be a bug-fix only now.

How Has This Been Tested?

Manual testing of the Telescope commands above.
NVIM v0.11.0-nightly+4a2a54f
macOS 15.3.1

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code

@sibouras
Copy link

I'm open to suggestions on how to handle that.

u can add the new change inside vim.fn.has('nvim-0.11') == 1

@dustypomerleau dustypomerleau changed the title fix(lsp)!: add default position encoding when calling symbols_to_items()' fix(lsp): add default position encoding when calling symbols_to_items()' Feb 23, 2025
@dustypomerleau dustypomerleau marked this pull request as ready for review February 23, 2025 23:07
@dustypomerleau
Copy link
Contributor Author

I'm open to suggestions on how to handle that.

u can add the new change inside vim.fn.has('nvim-0.11') == 1

Thanks @sibouras! I've made the change. Should be ready for review now.

@jamestrew jamestrew self-assigned this Mar 3, 2025
@dustypomerleau dustypomerleau marked this pull request as draft March 8, 2025 08:14
@dustypomerleau dustypomerleau marked this pull request as ready for review March 8, 2025 09:03
@dustypomerleau
Copy link
Contributor Author

Thanks for the detailed review @dhruvmanila - I wasn't familiar with the API. Please have a look @jamestrew and see if you're happy.

@dustypomerleau dustypomerleau changed the title fix(lsp): add default position encoding when calling symbols_to_items()' fix(lsp): add position encoding when calling symbols_to_items()' Mar 8, 2025
@jamestrew jamestrew merged commit a17d611 into nvim-telescope:master Mar 17, 2025
12 checks passed
@jamestrew
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants