-
-
Notifications
You must be signed in to change notification settings - Fork 917
fix(lsp): add position encoding when calling symbols_to_items()
'
#3418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lsp): add position encoding when calling symbols_to_items()
'
#3418
Conversation
u can add the new change inside |
20bfb8f
to
702eddd
Compare
symbols_to_items()
'symbols_to_items()
'
Thanks @sibouras! I've made the change. Should be ready for review now. |
702eddd
to
e67962f
Compare
e67962f
to
ebc4105
Compare
ebc4105
to
ea74c49
Compare
Thanks for the detailed review @dhruvmanila - I wasn't familiar with the API. Please have a look @jamestrew and see if you're happy. |
symbols_to_items()
'symbols_to_items()
'
ea74c49
to
5df9d9e
Compare
5df9d9e
to
0c4d088
Compare
0c4d088
to
194cfe5
Compare
Thanks! |
Description
neovim/neovim#30860 introduced the
position_encoding
parameter insymbols_to_items()
. This breaks:Telescope lsp_document_symbols
,lsp_workspace_symbols
, andlsp_dynamic_workspace_symbols
for anyone running nightly Neovim.Type of change
EDIT: draft status removed. Should be a bug-fix only now.
How Has This Been Tested?
Manual testing of the
Telescope
commands above.NVIM v0.11.0-nightly+4a2a54f
macOS 15.3.1
Checklist: