feat(pickers): improve center strategy by adding results_height
option
#3489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've been using this patched version of the
center
layout strategy for a while and thought it was worth proposing upstream. It introduces a new layout option, results_height, allowing users to explicitly set the height of the results panel.In addition, this refactors how window dimensions and positions are calculated, properly centring the entire layout (including preview, results, and prompt), rather than just the prompt + results block.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I've tested this change with different configurations, such as
mirror
,prompt_position
,height
and with the new optionresults_height
Dropdown theme
with
mirror = true
with
results_height = 5
with
results_height = 5
andmirror = true
with
prompt_position = 'bottom'
with
height = 40
andresults_height = 10
Configuration
Checklist: