-
-
Notifications
You must be signed in to change notification settings - Fork 917
fix: deprecated code, wrong annotations #3540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DrKJeff16
wants to merge
10
commits into
nvim-telescope:master
Choose a base branch
from
DrKJeff16:patch/deprecations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
3442980
to
291c2c8
Compare
Signed-off-by: Guennadi Maximov C <[email protected]>
291c2c8
to
b6e2b32
Compare
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
NoteThis is an extended list of fixes offered originally in #3502. |
3 tasks
Signed-off-by: Guennadi Maximov C <[email protected]>
289e38e
to
3421826
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Throughout the codebase there have been lots of deprecated code used. Some examples include:
vim.validate()
: Reported here and in vim.validate is deprecated. Feature will be removed in Nvim 1.0 #3499vim.loop
: We havevim.uv
nvim_win_set_option()
/nvim_buf_set_option()
: Replaced bynvim_set_option_value()
nvim_buf_add_highlight()
: Replaced byvim.hl.range()
nvim_err_writeln()
: Replaced bynvim_echo()
(according to the Neovim Deprecated docsI have updated the deprecated code and, for
vim.validate()
andvim.loop
I have set them as fallback dependingon either version or availability, respectively.
Fixes this r/neovim report and #3499.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I have ran
make test
with no failures nor warnings.Configuration:
DrKJeff16/Jnvim
Checklist: