-
-
Notifications
You must be signed in to change notification settings - Fork 924
ci: add luals workflow #3563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ci: add luals workflow #3563
Conversation
...pretty bad. |
5707890 to
cf19759
Compare
|
yeah, we dont have typing, luals wasnt that mature back then 😅 |
|
I guess all these luacats annotations we have are for something different then ;) |
|
|
||
| stylua: | ||
| name: stylua | ||
| name: Stylua |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: This requires adapting the branch protection (required checks are case sensitive).
Since we're basically starting from scratch, we might as well switch to emmyluals already, which is quite a bit faster and has better support for generics. (It's also quite a bit stricter and still has some rough edges, and the Nvim runtime itself is not fully emmyluals compliant, which may be a problem.) |
annotations where used for doc generation, not type hints: https://github.com/tjdevries/tree-sitter-lua/blob/master/HOWTO.md but i think that one broke 2 years ago |
|
Yeah, I noticed on another PR (which is what started this whole rampage) ;) |
|
emmyluals has a docgen CLI; that could be another argument for switching, if we have to replace tools anyway. |
Optional for now; can be run locally with `make luacheck`.
Optional for now; can be run locally with
make luacheck. (I just want to see how bad this is going to be...)Also fix the lint workflow:
/luathese days)