Fix(diagnostics) not showing when severity_sort is disabled #1532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Diagnostics were not being displayed when the severity_sort option was not enabled in vim.diagnostic.config(). This issue occurred because the generate_list function only called the callback when severity_sort was set to true, leaving the diagnostics unprocessed in the opposite case.
Solution:
The generate_list function has been modified to always call the callback with the generated list, regardless of whether severity_sort is enabled. This ensures that diagnostics are displayed correctly in all scenarios. Additionally, unnecessary return statements were removed since the caller does not use the return value, simplifying the code.
This fix provides a consistent user experience by ensuring diagnostics work as expected, whether sorting by severity is enabled or not.
Fixes #1520