JS Tests #6
Open
JS Tests #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikkyAI
force-pushed
the
feature/multi-platform
branch
2 times, most recently
from
0635935 to
3daad95
Compare
nwillc
reviewed
Feb 7, 2020
settings.gradle.kts
Outdated
| @@ -1 +1 @@ | |||
| rootProject.name = "ksvg" | |||
| //rootProject.name = "ksvg" | |||
Owner
There was a problem hiding this comment.
Why did the project name need to be removed?
Contributor
Author
There was a problem hiding this comment.
this is by accident.. it is integrated into a bigger project on my end
| href = "#circle1" | ||
| } | ||
| } | ||
| // FileWriter("/tmp/circlesDiagonal.svg").use { |
Owner
There was a problem hiding this comment.
Without this "file test" actually writing a file, which I understand it can't in JS, what is being "tested". Is there an assertion we could make on the results?
Contributor
Author
There was a problem hiding this comment.
wanted to change this into document.getElementById or html-dsl code
| } | ||
| } | ||
|
|
||
| // FileWriter("/tmp/codeMonkey.svg").use { |
Contributor
Author
There was a problem hiding this comment.
this is obviously not working because such a thing does not exist on js
and i wanted to keep it around as a comment to remind me to replace this
NikkyAI
force-pushed
the
feature/multi-platform
branch
from
e1fdc2d to
41c9ef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so far i fixed up test names with
@JsNamethis works, testnames are still reported with spaces, but it is a pain to write a extra linetest tasks
allTests,jsBrowserTesthave to be started withCHROME_BINenv variable settest failures mentioned here still exist: #3 (comment)