fix(util): update getManifest return type and handle empty response #1410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Line 66 in 548d0e5 This also needs to be updated, probably why tests are failing |
|
Also what is being fixed here? Is this semantic or just a presentational change? |
ayushmanchhabra
force-pushed
the
remove-undefined
branch
from
01c6a1f to
99fce8c
Compare
|
I would think that running code like the following could lead to bugs. var chunks = undefined;
chunks += '{"data":"stuff"}'; // undefined{"data":"stuff"}
if (chunks !== undefined) chunks = chunks.slice(9); // {"data":"stuff"}So, this is a small refactor. |
ayushmanchhabra
pushed a commit
that referenced
this pull request
Jul 8, 2025
🤖 I have created a release *beep* *boop* --- ## [4.13.16](v4.13.15...v4.13.16) (2025-07-07) ### Bug Fixes * **util:** update getManifest return type and handle empty response ([#1410](#1410)) ([c287c07](c287c07)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the word undefined from the stored data is a weird choice. This changes that.