Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage "trust me bro" bug #755

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Andrew-Dickinson
Copy link
Member

@Andrew-Dickinson Andrew-Dickinson commented Nov 28, 2024

Triages the bug where we currently throw away the user's "trust me bro" preference on the join form. Based on this flowchart @WillNilges and I agreed on a few weeks ago as intermediate state:

MeshDBAddressValdiation-New State drawio

This makes things better, but is far from optimal. We really need to re-work the whole thing to be more consistent and predictable in the case that the city api doesn't give good answers. And to support NJ

TODO:

  • Supplement TODO entries with GH issues
  • Send slack messages per the flowchart
  • Make tests happy
  • Add new address truth source to distinguish join form humans from volunteers. OSM isn't really the truth source here

@Andrew-Dickinson Andrew-Dickinson changed the title Add tests to expose "trust me bro" bug Triage "trust me bro" bug Jan 3, 2025
@Andrew-Dickinson Andrew-Dickinson force-pushed the andrew/fix-trust-me-bro branch from 158e601 to 6ff3b6a Compare January 3, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant