Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link from the NN Re-assigned install to the node that got its number #798

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Andrew-Dickinson
Copy link
Member

@Andrew-Dickinson Andrew-Dickinson commented Dec 31, 2024

Screenshot 2024-12-31 at 00 44 10

Adds an "eye" icon to installs in the NN Reassigned status which links back to the node that got the install's number. Useful if you ever end up on the old install object instead of the node by mistake

Installs that are not "NN Reassigned" are unchanged:

Screenshot 2024-12-31 at 00 50 32

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (c76914d) to head (3060189).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
+ Coverage   94.88%   94.90%   +0.02%     
==========================================
  Files          89       89              
  Lines        3809     3826      +17     
==========================================
+ Hits         3614     3631      +17     
  Misses        195      195              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.



# Down here to resolve circular imports
from meshapi.admin.models.install import InstallAdminForm # noqa: E402
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh that's a little cursed. Do you think there's another way to resolve the circular imports?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a few other things, but nothing works. The most common way to solve this is to use import x; x.y instead of from x import y but I think our liberal use of from .x import * statements in __init__ is causing some issues with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants