Update Admin Panel to work via iframes #799
Conversation
WillNilges
force-pushed
the
wdn/map-iframe-2
branch
from
a03723e to
c0c8983
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This reverts commit 27b0919.
src/meshdb/templates/admin/password_reset/password_reset_complete.html
Outdated
Show resolved
Hide resolved
|
|
||
| # TODO (wdn): Add more tests checking if navigating to xyz page works | ||
| # Unfortunately, because that is a lot of javascript, it's tricky to test. | ||
| # It may be possible to run selenium integration tests or something to validate |
There was a problem hiding this comment.
I'd support selenium-based tests for integration testing deployed copies of the application (dev, gamma, etc) but probably we don't want it in our unit testing pipeline, those things are slow enough already
There was a problem hiding this comment.
Probably not in our unit testing pipeline, no. Are you OK with me handling this in a separate PR or would you like me to take a crack at a solution for this here?
|
Doing some local testing and noticed a few issues:
Overall it feels much snappier though, great job on the performance improvements |
That's odd. My last commit should have fixed that. Did you pull the latest?
Fixed
Should be fixed |
|
|
||
|
|
||
| @staff_member_required | ||
| def admin_iframe_view(request: HttpRequest) -> HttpResponse: |
There was a problem hiding this comment.
Might want to add a test for this authentication/redirect
src/meshweb/static/admin/map.js
Outdated
| if (url.pathname.startsWith("/admin/logout")) return true; | ||
| if (url.pathname.endsWith("/export/") && isForm) return true; | ||
| if (url.host !== location.host) return true; | ||
| console.log(`Admin Panel src set to: ${admin_panel_iframe.src}`); |
There was a problem hiding this comment.
Might want to gate all these log lines with a debug statement or something for cleanliness.
Refactors the way the map is incorporated into the admin panel. Instead of embedding it and doing a lot of tricks to update the DOM, it puts the admin panel and the map into their own iframes, and ties them together with a little JavaScript secret sauce.
/adminStill a lot to do on this: