-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readiness + Startup probes #804
Changes from all commits
3839ab4
1105bbf
936ce42
4c85194
41bd853
ce88e06
4643999
df0b702
73e179f
021bd9a
e61306f
490f30e
672c5e0
9510b3a
1c71ea2
2e13275
b6ab9be
68743f8
53d1f73
d9e3ddf
013cca3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,18 +47,38 @@ spec: | |
mountPath: /opt/meshdb/static | ||
{{ if eq .Values.meshweb.liveness_probe "true" }} | ||
livenessProbe: | ||
exec: | ||
command: | ||
- curl | ||
- http://127.0.0.1:{{ .Values.meshweb.port }}/api/v1 | ||
periodSeconds: 3 | ||
initialDelaySeconds: 4 | ||
timeoutSeconds: 3 | ||
{{ end }} | ||
livenessProbe: | ||
{{- toYaml .Values.livenessProbe | nindent 12 }} | ||
exec: | ||
command: | ||
- bash | ||
- -c | ||
- 'curl http://127.0.0.1:{{ .Values.meshweb.port }}/api/v1/ -H "Host: db.nycmesh.net" -s | grep meshin' | ||
periodSeconds: 10 | ||
initialDelaySeconds: 30 | ||
timeoutSeconds: 3 | ||
{{ end }} | ||
{{ if eq .Values.meshweb.readiness_probe "true" }} | ||
readinessProbe: | ||
{{- toYaml .Values.readinessProbe | nindent 12 }} | ||
exec: | ||
command: | ||
- bash | ||
- -c | ||
- 'curl http://127.0.0.1:{{ .Values.meshweb.port }}/api/v1/ -H "Host: db.nycmesh.net" -s | grep meshin' | ||
periodSeconds: 3 | ||
initialDelaySeconds: 10 | ||
timeoutSeconds: 3 | ||
{{ end }} | ||
{{ if eq .Values.meshweb.startup_probe "true" }} | ||
startupProbe: | ||
exec: | ||
command: | ||
- bash | ||
- -c | ||
- 'curl http://127.0.0.1:{{ .Values.meshweb.port }}/api/v1/ -H "Host: db.nycmesh.net" -s | grep meshin' | ||
periodSeconds: 3 | ||
initialDelaySeconds: 20 | ||
timeoutSeconds: 3 | ||
failureThreshold: 20 | ||
{{ end }} | ||
Comment on lines
+61
to
+81
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think it's worth having redundant probes. We should consider what kind of probes to use in place of these. Maybe we should just check if we get anything back from nginx at all as the liveness probe, then make the readiness probe check Not sure about startupProbe There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, I think I might be wrong to suggest that.
|
||
resources: | ||
{{- toYaml .Values.meshweb.resources | nindent 12 }} | ||
volumes: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The grep is fine but knowing that it's
we're meshin'
confused my brain for a sec lol